-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruby 3.3 for Windows CI #3393
base: dev
Are you sure you want to change the base?
Conversation
3.2 has issues with non-English entries in Registry.
Have kicked it off. Fingers crossed 😄 |
Linux and Mac failed while building Windows built successfully but failed at
which is cryptic as well - both the last commit changing the workflow aa63dc7 and the last commit built before mine fa6e49f were built successfully... This might be just a random CI quirk requiring a simple re-run, but I kinda doubt it. |
I just updated vcpkg to the latest release and it still seems to be failing as described above. Not sure what's going on here at all. I did manage to build things successfully with Qt 6.7 on my Apple Silicon Mac - so it's possible it might be an issue with vcpkg and the CI? If anyone can help I'd love to hear your thoughts.... Oh, and updating Ruby to 3.3 in the CI only affects the tests. Release builds are currently manually built - and Sonic Pi is designed to support Ruby back to v2.x |
Possibly related: microsoft/vcpkg#38112 (comment) |
I might take a look at it at some point in a fork, but I am knee-deep in other random stuff nowadays, so I cannot promise anything 😅
Yup, figured that much since the only upload in the workflow is related to logs 🙃 . Wanted simply to check preemptively that the upgrade wouldn't break the build at the very least. |
For the record, today I built the latest Sonic Pi with Ruby 3.3 and Qt 6.7 on my Windows machine and it seems to be working just fine. |
Ruby 3.2 has issues with non-English entries in Registry.
Relates to #3371 and probably other crash reports mentioning
Error reading ports via Boot Daemon STDOUT
.UPD: Was going to simply check if the project even builds with 3.3, but GHA says
This workflow is awaiting approval from a maintainer
😞