Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Autotuner fx #3088

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

xavriley
Copy link
Collaborator

Implements a new autotune, which is closer to the Antares original.

It doesn't use FFTs - instead everything happens in the time domain.
This version of the effect has options for transpose, key and scale
along with note as a target note. Performance should be better than the
other autotuner effect which exists in SP currently.

See @xavriley/qlibugens for the original plugin. Binaries are available
on the Releases page here https://github.com/xavriley/qlibugens/releases

Implements a new autotune, which is closer to the Antares original.

It doesn't use FFTs - instead everything happens in the time domain.
This version of the effect has options for transpose, key and scale
along with note as a target note. Performance should be better than the
other autotuner effect which exists in SP currently.

See @xavriley/qlibugens for the original plugin. Binaries are available
on the Releases page.
@level-xx
Copy link
Contributor

Hi Xavier, just heard your sound sample. This is really great! When will this and the new :vocoder FX make it into main? Ben

@xavriley
Copy link
Collaborator Author

xavriley commented Sep 1, 2023

I've fixed the merge conflict now - it's been a while but I think the reason this didn't get merged in right away was because Sam wanted to have a think about the best way to package/deliver SuperCollider external UGens that were outside of SC3. I'm not sure if we ever made a decision about that. This is ready to merge anyway.

@level-xx
Copy link
Contributor

I've fixed the merge conflict now - it's been a while but I think the reason this didn't get merged in right away was because Sam wanted to have a think about the best way to package/deliver SuperCollider external UGens that were outside of SC3. I'm not sure if we ever made a decision about that. This is ready to merge anyway.

Great, looking forward to it. The external UGen integration in SP is also very interesting for me.

@samaaron
Copy link
Collaborator

Hiya,

apologies - this dropped off my radar. It's definitely something I'd like to see eventually merged into Sonic Pi.

However, for it to happen I feel that we need to be able to compile the ugen from source as part of the building process. This is certainly a hard requirement for it to be packaged for a linux distribution.

@xavriley - how is the ugen built? Could it be integrated into our cmake build process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants