Issue#27: Add references to projection note #28
Conversation
| @@ -113,7 +113,7 @@ \subsection{Vector form} | |||
| \nabla \cdot \mathbf{v}=0 \label{e:continuity_vec} | |||
| \end{align} | |||
| % | |||
| \section{Projection algorithm} | |||
There was a problem hiding this comment.
References should be added in paragraphs instead of section headers.
| @@ -113,7 +113,7 @@ \subsection{Vector form} | |||
| \nabla \cdot \mathbf{v}=0 \label{e:continuity_vec} | |||
| \end{align} | |||
| % | |||
| \section{Projection algorithm} | |||
| \section{Projection algorithm \cite{ferziger_cfd_2019}} | |||
| Velocity at $n^{th}$ time-step is denoted as $\mathbf{v}^n$. Convection term is | |||
There was a problem hiding this comment.
Please write something about the numerical method you are employing in this note. Conventionally we (scientists and engineers) call them numerical methods, not algorithms. The term algorithm is mostly used by programmers.
…odify the content from 3-step projection method to 4-step projection method.
| Solve for $\mathbf{v}^{n+1}$, we need to decide $\mathbf{P}$ beforehand. Projection | ||
| algorithm is implemented with intermediate term $\mathbf{v}^{*}$, the momentum | ||
| equation is split into 2 parts: | ||
| Projection method\cite{ferziger_cfd_2019} split eq (\ref{e:momentum_pj}) into |
There was a problem hiding this comment.
Conventionally we add citation at the end of a sentence. But at the time being it is OK to leave it here. We can come back here to change later.
There was a problem hiding this comment.
And I wonder if you can pin-point to the original paper for the Projection Method?
There was a problem hiding this comment.
Sure, we can change it later; yes, this sounds more reasonable to me. Should they be included in a new issue?
There was a problem hiding this comment.
Sounds like a plan. Could you file an issue for yourself?
|
@EN-Chou I updated your permission and you should be able to merge the PR yourself. Could you please give it a try? |
This commit works on issue #27, add references to projection note.