Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: how cloudflare pages adapter checks for static asset request and give start a chance to handle request if not found #998

Merged
merged 4 commits into from
Aug 14, 2023
Merged

fix: how cloudflare pages adapter checks for static asset request and give start a chance to handle request if not found #998

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70cfbd1
fix bug where cloudflare pages adapter looks for file ending in query…
edivados Aug 12, 2023
f9d6529
now fixed
edivados Aug 12, 2023
5d07910
Update entry.js
edivados Aug 12, 2023
6a7546e
Merge branch 'main' into cloudflare-pages-regex
ryansolid Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/start-cloudflare-pages/entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import handler from "./entry-server";

export const onRequestGet = async ({ request, next, env }) => {
// Handle static assets
if (/\.\w+$/.test(request.url)) {
if (/\.\w+$/.test(new URL(request.url).pathname)) {
let resp = await next(request);
if (resp.status === 200 || 304) {
if (resp.status === 200 || resp.status === 304) {
return resp;
}
}
Expand Down Expand Up @@ -44,9 +44,9 @@ export const onRequestGet = async ({ request, next, env }) => {

export const onRequestHead = async ({ request, next, env }) => {
// Handle static assets
if (/\.\w+$/.test(request.url)) {
if (/\.\w+$/.test(new URL(request.url).pathname)) {
let resp = await next(request);
if (resp.status === 200 || 304) {
if (resp.status === 200 || resp.status === 304) {
return resp;
}
}
Expand Down
Loading