Stop choking if BASE_URL includes origin (fix #979) #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Not sure how to test this: Do we have any tests that set a flag in vite, and then run the app to see there are no errors?
We could also move the code change into
@solidjs/router, but this is a fix for SolidStart, and I'm not sure where it makes the most sense to add this small guard.PR Type
What is the current behavior?
Setting this in
vite.config.ts:Would cause Solid's router to crash, because it wasn't expecting base urls to include origins. Solid's router expects a base path, without an origin.
What is the new behavior?
Before we pass Vite's BASE_URL to Solid's router, check for and remove any origin, by checking if the BASE_URL starts with
'http'.Closes #979