fix: save configuration in .lint folder if run.saveConfig enabled #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
То хубаво, ама така ще "изтекат" разни креденшъли от jenkins. Не, че няма и други начини да изтекат, просто се чудя ... Иначе би било полезно да може да запишем конфигурацията и преди да се мърджне, защото и това трудно се проследява вече. |
|
Да, точно преди това я има и не мърджната конфигурацията и лесно ще я запишем, но наистина би могло да се счете за някакъв вид security проблем, макар и дженкинса да е във вътрешната мрежа само. Иначе дори и локално пак би могло да е полезна тази информация и да спести дебъгване в доста случаи. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run.saveConfig configuration