Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement built-in cache support #8

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Conversation

szymmis
Copy link
Contributor

@szymmis szymmis commented Aug 2, 2023

Resolves #2.

Using @actions/toolkit Scarb cache saving/restoring is now supported out of the box. Cache key is based on sha256 has of Scarb.toml file which is retreived by path returned from scarb manifest-path. Right now cache directories paths are hardcoded into the action but in the future there is a possibility to make a command in Scarb that will return cache directory as other package managers such as npm or yarn are doing.

@szymmis szymmis requested a review from mkaput as a code owner August 2, 2023 08:49
@mkaput
Copy link
Member

mkaput commented Aug 2, 2023

Cache key is based on sha256 has of Scarb.toml file

Please make an issue to hash the lockfile, so we won't forget about this in the future. There's an action in this repository which automatically adds all issues to our board -- make sure to transition the task to TODO when it will be added :) Thanks!

lib/cache-save.js Outdated Show resolved Hide resolved
lib/cache-restore.js Outdated Show resolved Hide resolved
@szymmis szymmis added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 321b326 Aug 2, 2023
5 checks passed
@szymmis szymmis deleted the szymmis/setup-scarb-cache branch August 2, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement built-in cache support
2 participants