-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated workflow publishing capabilities #29
Conversation
✅ Deploy Preview for test-almanac ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! All the changes look pretty straightforward. I also tried out the build-book
and build-book-pdf
commands locally, both of which ran to completion (including fetching Chromium, which was cool to see) and produced nice-looking output.
I've noticed that, in the PDF version of the book and when you select the ".pdf" option from the "Download" dropdown in the HTML version, the PDF has a "Skip to main content" overlay on each page that covers up some of the content. Here's an example from the PDF:
I'm approving this PR since that issue is out of scope for automating the build process, but I thought I'd mention it. I can file an issue for this one and these sorts of things in the future, if you like.
Thanks @falquaddoomi and @gwaybio for the reviews!
Thanks for bringing this up! I did some investigation and found that this relates to jupyter-book/jupyter-book#2045 and pydata/pydata-sphinx-theme#1745 . I've added a bit of CSS to avoid displaying the "skip" content when printing through Chromium (which is how the PDF is compiled). |
Description
This PR adds the capability to publish the Almanac's content automatically through GitHub Actions to address #18 . This adds HTML and PDF content through GitHub Pages. I tried to include ePub with this work but found that it's more complicated than the HTML or PDF content publishing process. As a result, I plan to address that aspect outside this PR, but I don't consider it critical (as both an offline and online option are provided here).
I also noticed that:
Thanks for any feedback you may have!
Closes #18 (#30 created for ePub tracking as follow-up)
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.