Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for unique and active contributor counts #182

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 22, 2024

Description

This PR adds metrics which count unique contributors in various ways. I use this to help interpret "active contributors" by looking at the number of unique contributors within the last year and 182 days (roughly half a year). In addition, I also added a metadata field which allows the table contents to have a relative datetime stamp which may be useful for understanding the unique contributors per 1 year and per 182 days since the time the table was generated.

Thanks for any feedback!

Closes #159

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs changed the title Add metrics for unique contributor counts Add metrics for unique and active contributor counts Nov 22, 2024
@d33bs d33bs marked this pull request as ready for review November 22, 2024 13:31
Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! All the code looks good and makes sense to me, and the metrics you added are useful; kudos.

src/almanack/metrics/data.py Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Nov 22, 2024

Thanks @falquaddoomi ! Going to merge this in.

@d33bs d33bs merged commit 1b3b4cb into software-gardening:main Nov 22, 2024
11 checks passed
@d33bs d33bs deleted the contributors branch November 22, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Biomedical research meaningful measures: Table 4 - Version control - Number of active contributors
2 participants