Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SBOM checks and file #180

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 21, 2024

Description

This PR removes the SBOM checks and file from the repo, which have been cause for various challenges. In general, SBOM use is evolving, and our use case here may be unhealthy or unexpected based on existing tools in this space. In the future it might be useful to explore how SBOM's are included with packaged artifacts of the project such as those found in releases and possibly enabled by: https://github.com/anchore/sbom-action or other works which may appear over time.

References #179 (where Will is experiencing issues because of this)
References #174 (which we would close without merge as a result of this change)

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review November 21, 2024 17:15
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer! But good to garden quick! 🏡

@d33bs
Copy link
Member Author

d33bs commented Nov 21, 2024

Thanks @gwaybio ! Merging this in.

@d33bs d33bs merged commit 1b9b8e1 into software-gardening:main Nov 21, 2024
11 checks passed
@d33bs d33bs deleted the remove-sbom-check branch November 21, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants