Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for checking common documentation paths #164

Merged
merged 10 commits into from
Nov 13, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 8, 2024

Description

This PR adds a metric which checks for "common documentation" paths within a given repository. We perform this measurement in alignment with #150. As part of measuring how the Almanack itself meets this standard I created a docs directory with a reference to where to find the documentation for this project. As a minor note to this effect, the book content is currently stored within the src as it is included with the package builds for reading through the Python package.

I feel we could continue to work on #150 with another change after this which involves looking at common GitHub Pages locations based on the git remotes listing of a repository (which would likely yield an HTTP link we could use to form the default GitHub pages default). We could also check for docs badging within the main readme. Either way, I thought these changes might be better outside this PR, as they're a bit different in nature.

References #150

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review November 8, 2024 15:42
Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for documentation seems useful, cheers to that. 😄 AFAICT there weren't any issues with your code, but I made a few comments that I hoped might help simplify it by leveraging existing functionality in the libraries you're using.

src/almanack/git.py Outdated Show resolved Hide resolved
src/almanack/metrics/data.py Outdated Show resolved Hide resolved
tests/data/almanack/repo_setup/create_repo.py Outdated Show resolved Hide resolved
tests/metrics/test_data.py Outdated Show resolved Hide resolved
tests/metrics/test_data.py Show resolved Hide resolved
@d33bs d33bs linked an issue Nov 12, 2024 that may be closed by this pull request
@d33bs
Copy link
Member Author

d33bs commented Nov 13, 2024

Thanks @falquaddoomi for the review! I've addressed your comments with various updates. Please let me know if there's anything else I may do to help meet an approval for this PR.

Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@d33bs
Copy link
Member Author

d33bs commented Nov 13, 2024

Thanks @falquaddoomi ! Merging this in now.

@d33bs d33bs merged commit 2685c7d into software-gardening:main Nov 13, 2024
12 checks passed
@d33bs d33bs deleted the check-for-docs branch November 13, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Biomedical research meaningful measures: Table 3 - Web presence
2 participants