-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for checking common documentation paths #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking for documentation seems useful, cheers to that. 😄 AFAICT there weren't any issues with your code, but I made a few comments that I hoped might help simplify it by leveraging existing functionality in the libraries you're using.
Co-Authored-By: Faisal Alquaddoomi <[email protected]>
Co-Authored-By: Faisal Alquaddoomi <[email protected]>
Co-authored-by: Faisal Alquaddoomi <[email protected]>
Thanks @falquaddoomi for the review! I've addressed your comments with various updates. Please let me know if there's anything else I may do to help meet an approval for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks @falquaddoomi ! Merging this in now. |
Description
This PR adds a metric which checks for "common documentation" paths within a given repository. We perform this measurement in alignment with #150. As part of measuring how the Almanack itself meets this standard I created a docs directory with a reference to where to find the documentation for this project. As a minor note to this effect, the
book
content is currently stored within thesrc
as it is included with the package builds for reading through the Python package.I feel we could continue to work on #150 with another change after this which involves looking at common GitHub Pages locations based on the git remotes listing of a repository (which would likely yield an HTTP link we could use to form the default GitHub pages default). We could also check for docs badging within the main readme. Either way, I thought these changes might be better outside this PR, as they're a bit different in nature.
References #150
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.