Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measure for repository default branch as not master #128

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Oct 27, 2024

Description

This PR adds a measure to check whether the default branch is not named master (can be named anything besides this).

Thanks for any feedback!

Closes #119

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review October 28, 2024 13:47
src/almanack/metrics/data.py Outdated Show resolved Hide resolved
src/almanack/metrics/metrics.yml Outdated Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Oct 28, 2024

Thanks @gwaybio ! I've made a few changes based on your feedback - namely that we now look for a remote head and matching master reference. Merging this in now.

@d33bs d33bs merged commit 9faef20 into software-gardening:main Oct 28, 2024
11 checks passed
@d33bs d33bs deleted the default-branch-master-measure branch October 28, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement measure for default branch naming as something besides master
2 participants