-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add manual trigger #31
Conversation
WalkthroughThe changes introduce a new trigger, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Terraform Jobs
User->>GitHub Actions: Trigger workflow (manual or pull_request)
GitHub Actions->>Terraform Jobs: Execute jobs (settings, test, sonarcloud, plan, deploy, seed, destroy)
Terraform Jobs-->>GitHub Actions: Completion status
GitHub Actions-->>User: Notify completion
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/terraform.yaml (1)
Line range hint
44-45
: Update job conditions to handle manual triggersThe current job conditions don't account for manual workflow runs. Consider updating the following conditions to include
workflow_dispatch
:
- Test job:
- if: github.event_name == 'push' + if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
- SonarCloud job:
- if: github.event_name == 'pull_request' || github.ref == 'refs/heads/main' + if: github.event_name == 'pull_request' || github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch'
- Terraform Plan job:
- if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
- Deploy job:
- if: github.ref == 'refs/heads/main' + if: github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch'This ensures that manual triggers go through the same validation steps as automated runs.
Also applies to: 71-72, 91-92, 147-148
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/terraform.yaml
(1 hunks)
🔇 Additional comments (2)
.github/workflows/terraform.yaml (2)
7-7
: LGTM: Manual trigger addition
The addition of workflow_dispatch
trigger enhances workflow flexibility by allowing manual runs.
Line range hint 15-16
: LGTM: Security controls are well-maintained
The workflow maintains proper security controls with:
- Appropriate permission restrictions
- Environment-gated deployments
- Proper secrets handling
Terraform Cloud Plan Output
|
No description provided.