Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #26 from soat-fiap/fix_destroy_plan #27

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

italopessoa
Copy link
Member

fix destroy plan

Copy link

coderabbitai bot commented Sep 23, 2024

Walkthrough

The change involves updating the reference for the workspace parameter in the Terraform Cloud workflow configuration file. The reference was changed from ${{ vars.TF_WORKSPACE }} to ${{ env.TF_WORKSPACE }}, shifting the source of the TF_WORKSPACE variable from a variable context to an environment context.

Changes

File Change Summary
.github/workflows/terraform.yaml Updated workspace parameter reference from ${{ vars.TF_WORKSPACE }} to ${{ env.TF_WORKSPACE }}.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a708bf8 and aafbd3a.

Files selected for processing (1)
  • .github/workflows/terraform.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/terraform.yaml (1)

300-300: LGTM! Consistent use of environment variable.

The change from ${{ vars.TF_WORKSPACE }} to ${{ env.TF_WORKSPACE }} aligns with how the variable is defined at the top of the file. This ensures consistency in how the workspace is referenced throughout the workflow.

To ensure this change doesn't break the workflow, please verify that the TF_WORKSPACE environment variable is correctly set and accessible in this job. You can add a step before the "Create plan" step to echo the value:

      - name: Echo TF_WORKSPACE
        run: echo "TF_WORKSPACE is set to: ${{ env.TF_WORKSPACE }}"

      - name: Create plan
        uses: hashicorp/tfc-workflows-github/actions/[email protected]
        id: destroy-plan
        with:
          workspace: ${{ env.TF_WORKSPACE }}
          configuration_version: ${{ needs.deploy.outputs.config_version }}
          is_destroy: true

This will help confirm that the environment variable is properly set and available for use in the destroy-plan job.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link

Terraform Cloud Plan Output

```
Plan: 3 to add, 0 to change, 0 to destroy.
```
[Terraform Cloud Plan](https://app.terraform.io/app/FiapPostech-SOAT/workspaces/bmb-database/runs/run-a1zY6aH2jJBwZF5T)

@italopessoa italopessoa merged commit 4e35f57 into main Sep 23, 2024
8 checks passed
@italopessoa italopessoa deleted the fix_destroy_plan_env branch September 28, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant