fix: return ecosyste.ms license based on package version #88
+97
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcombuechen
reviewed
Nov 28, 2024
Comment on lines
+56
to
+59
| // Ecosyste.ms has a purl based API, but unfortunately slower | ||
| // so we break the purl down to registry and name values locally | ||
| // params := packages.LookupPackageParams{Purl: &p} | ||
| // resp, err := client.LookupPackageWithResponse(context.Background(), ¶ms) |
There was a problem hiding this comment.
can we remove this? including the comment about the purl api? i don't find it particularly useful 😄
| expression := data.NormalizedLicenses[0] | ||
| func enrichCDXLicense(comp *cdx.Component, data *packages.Version) { | ||
| if data.Licenses != nil { | ||
| if *data.Licenses != "" { |
There was a problem hiding this comment.
this looks a bit like a red flag. don't we have data.NormalizedLicenses on the package version response? this change would mean that we are potentially enriching with unsanitized data. e.g. MIT,Apache-2.0 is not a valid SPDX license expression.
There was a problem hiding this comment.
looks like the ecosyste.ms response for a specific package version doesn't have a normalised licenses field, no
There was a problem hiding this comment.
I raised an issue with ecosyste.ms about this here: ecosyste-ms/packages#960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enriching with ecosyste.ms, fetch the license based on the package version.
Closes #87