Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to accommodate to new directory structure. #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

impeeza
Copy link

@impeeza impeeza commented Aug 31, 2023

Description

A set of small changes to accommodate to new directory setup.

Now builds Switch version without problem, and solves #266

Thanks a lot to @godreborn to help diagnose the problem here and SMW repo.

Will this Pull Request break anything?

No, instead resolve the problem of build switch version introduced when directories was reorganized.

Suggested Testing Steps

Build Switch Version on MSYS.

A set of small changes to accommodate to new directory setup.

Now builds Switch version without problem, and solves snesrev#266

Thanks a lot to @godreborn to help diagnose the problem here and SMW repo.
@Mraulio
Copy link

Mraulio commented Sep 5, 2023

This helped me build the Switch version.

@impeeza
Copy link
Author

impeeza commented Oct 2, 2023

Hello there, anybody has been able to review this PR? any ETA for apply? regards.

@hgue
Copy link

hgue commented Feb 26, 2024

Can confirm this is working when building on Linux, please merge

@frcabral
Copy link

when I run on linux it says
cannot find ancilla.o: No such file or directory
for all dependencies that were previously on root folder and now are moved to src folder.
Building on debian.
Maybe I've missed something?

@godreborn
Copy link

when I run on linux it says cannot find ancilla.o: No such file or directory for all dependencies that were previously on root folder and now are moved to src folder. Building on debian. Maybe I've missed something?

just tested in ubuntu 20.04. works fine for me:
image

I'm assuming you didn't add the pr. I just went through impeeza's repo, using the patch as a branch. no issues with or without the rom.

@godreborn
Copy link

btw, I just tested debian on my laptop. it also worked fine, and a lot of stuff on that distro is outdated on my end, so you should be good as long as the patch is applied through a pr or branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants