Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop support for Python 3.8, add CI checks for 3.13 #182

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 22, 2024

3.8 recently went end-of-life and 3.13 was released.

  • Testing 3.13 is a no-brainer, especially since it removes a bunch of deprecated modules that we want to be sure we aren't using.
  • Removing 3.8 makes our life easier and is in line with our recent removal of python2 and <3.8 as python versions go end-of-life. Previous releases of fhirclient will still be pip-installable for 3.8.

The funnest new thing in 3.9 that we might consider using more heavily is "type hinting generics in standard collections".

i.e. saying list[str] instead of List[str]

But the current code base doesn't have much hinting at all, so no changes needed yet. But we can use that going forward.

@mikix mikix marked this pull request as ready for review October 22, 2024 15:32
@mikix mikix merged commit e19a871 into main Oct 22, 2024
5 checks passed
@mikix mikix deleted the mikix/py3.13 branch October 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants