Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

inputbar left button: fixes text-only button not being displayed #654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soscomp
Copy link

@soscomp soscomp commented Jan 3, 2018

PR Summary

Fixes that left button is not displayed when using only the button label but no image.
When using only a label for the left button it previously wasn't displayed at all.
This was due to constraints recalculation was only done when the image is changed but not when the label is changed.
Now label is monitored for changes too and constraints are coreetly updated therefore displaying text-only buttons corretly.

Test strategy

Replace the image of the left button with some text. Previous version won't show the button this one will.

When using only a label for the left button it previously wasn't displayed at all.
This was due to constraints recalculation was only done when the image is changed but not when the label is changed.
Now label is monitored for changes too and constraints are coreetly updated therefore displaying text-only buttons corretly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant