fix: possible race condition leading to 404s (#390)

skyra-project · Nov 17, 2024 · 4d41316 · 4d41316
1 parent c3e268f
commit 4d41316
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/http-framework/src/lib/interactions/structures/interactions/base/BaseInteraction.ts b/packages/http-framework/src/lib/interactions/structures/interactions/base/BaseInteraction.ts
@@ -245,7 +245,12 @@ export abstract class BaseInteraction<T extends BaseInteractionType = BaseIntera
 		if (response.writableEnded) throw new Error('Cannot send response, the request has already been replied.');
 
 		response.statusCode = HttpCodes.OK;
-		return new Promise<void>((resolve) => response.end(JSON.stringify(data), resolve));
+		return new Promise<void>((resolve) => {
+			response.on('close', () => {
+				resolve();
+			});
+			response.end(JSON.stringify(data));
+		});
 	}
 }