This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
fix #60 - writable for polyfilled properties #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -749,6 +749,8 @@ if (!('attachShadow' in document.createElement('div'))) { | |||
|
|
|||
| // All properties should be configurable. | |||
| memberProperty.configurable = true; | |||
| // Applying to the data properties only since we can't have writable accessor properties | |||
| !(memberProperty.hasOwnProperty('get') || memberProperty.hasOwnProperty('set')) && (memberProperty.writable = true); | |||
There was a problem hiding this comment.
It might be a more robust check to do something like:
if (memberProperty.hasOwnProperty('value')) {
memberProperty.writable = true
}Or something. I think the only one's we care about making writable are the ones we specify a hard value for. The ones we don't want to be writable we're specifying using the staticProp() function that uses Object.defineProperty().
What do you think?
|
Is there a test we should write for this? |
|
Don't know, maybe. |
|
Yeah, could write a test to see if we can override methods. |
|
lgtm |
| @@ -53,6 +53,13 @@ describe('shadow/polyfill', function () { | |||
| }); | |||
| } | |||
|
|
|||
| it('polyfilled properties with value should be writable', function() { | |||
| let elem = create('div'); | |||
There was a problem hiding this comment.
could be const, but nitpick :)
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is connected to the #41
Since jQuery uses assignment for removeEventListener in tests