Updates to address review comments #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that it's released, there is no need for Cargo.toml to specify the beta version. Note that Cargo.lock already locked 0.21.0.
sjperkins
suggested changes
May 6, 2024
| @@ -26,7 +26,7 @@ crate-type = ["cdylib", "rlib"] # rlib included just for testing | |||
| enum-map = "2.7.3" | |||
| itoa = "1.0.10" | |||
| katcp-codec-fsm = { path = "crates/fsm", features = ["pyo3"] } | |||
| pyo3 = { version = "0.21.0-beta.0", features = ["extension-module"] } | |||
| pyo3 = { version = "0.21.0", features = ["extension-module"] } | |||
There was a problem hiding this comment.
I think this also needs to be updated in the katcp-codex-fsm sub-crate?
There was a problem hiding this comment.
Good catch, thanks. Should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.