feat: deploy storybook #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seojunhwan
commented
Nov 12, 2023
Comment on lines
+28
to
+29
| yarn install --immutable | ||
| yarn lerna run build --stream --ignore next |
There was a problem hiding this comment.
next는 필요 없어서 제외합니다
| return dirname(require.resolve(join(value, "package.json"))); | ||
| } | ||
| const config: StorybookConfig = { | ||
| stories: ["../../**/*.stories.@(js|jsx|mjs|ts|tsx)"], |
There was a problem hiding this comment.
요게 ads에서 타 패키지들을 종합하여 배포하는 부분입니다
sjoleee
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
굿굿 좋으네여 지금은 TailwindTestComponent의 스타일이 스토리북에서 적용이 안되는데, 요거슨 ads-react에 테일윈드 의존성 추가하고 tailwind.config에 아래처럼 코드 추가해주면 되네요 ㅋㅋㅋㅋㅋ 거의 만병통치약;
const packagePath = require.resolve("@sjoleee/tailwind-test-component");
const packageDir = dirname(packagePath);
위 경로 찾아주는 코드는 진짜 컴포넌트 개발 시작하면 추가하는걸로 하고 머지 고고하시죠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적을 알려주세요.
스토리북을 배포(테스트)합니다!
어떤 변경사항이 있는지 알려주세요.
중점적으로 봐주었으면 하는 부분
CI가 잘 이행될까요?