Add debug print for intermediate values #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasnick
reviewed
Mar 9, 2020
There was a problem hiding this comment.
I like the idea of adding debug prints, but readability is arguably worse. How about instead of # print("bla") we define a function debug_print(...) that takes an array, and prints every element if global variable DEBUG is set to true? This should reduce the number of lines and avoids having to uncomment line-by-line to have debug output.
|
That sounds reasonable. |
and make reference code and pseudocode more consistent with each other
jonasnick
reviewed
Mar 16, 2020
This is better for playing around with the code. Now these these exceptions can really be raised when the verification during signing fails.
|
fixed, and added another commit that improves checking of the test vectors |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #188
Tell me if I overdid it. But I think it's still readable, in particular if you have syntax highlighting and the comments are displayed differently.
This also adjusts the variables to match the BIP text.
I should have based this on top of #196, sorry. Let's first get #196 merged and I can rebase.