Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment_dataloader helper API (PR 5 of N) #8

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bkmartinjr
Copy link
Member

Adds an API to safely create a torch.utils.daa.DataLoader object that works with this package.

@bkmartinjr bkmartinjr changed the title Add experiment_dataloader helper API Add experiment_dataloader helper API (PR 5 of N) Sep 23, 2024
@bkmartinjr bkmartinjr marked this pull request as ready for review September 23, 2024 20:43
Base automatically changed from bkmartinjr/add-GHA to bkmartinjr/initial-non-shuffling-code September 25, 2024 16:00
@ryan-williams ryan-williams force-pushed the bkmartinjr/initial-non-shuffling-code branch from 4a546ca to c0f32a1 Compare September 25, 2024 16:17
@ryan-williams ryan-williams force-pushed the bkmartinjr/initial-non-shuffling-code branch from c0f32a1 to d9c0ef4 Compare September 25, 2024 16:30
Base automatically changed from bkmartinjr/initial-non-shuffling-code to main October 3, 2024 21:35
Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accumulated some changes on top of this and #9 (bkmartinjr/add-dataloader-api...rw/9.1), but I will pull some of that into separate PRs.

Gonna go ahead and merge this and several of the its "children," it all looks great, thanks @bkmartinjr!

@ryan-williams ryan-williams merged commit 3d8bf2a into main Oct 15, 2024
24 checks passed
@ryan-williams ryan-williams deleted the bkmartinjr/add-dataloader-api branch October 15, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants