Update the MultiscaleImage API #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
commented
Oct 22, 2024
jp-dark
commented
Oct 22, 2024
jp-dark
requested review from
aaronwolen,
ihnorton,
johnkerl,
ktsitsi and
ivirshup
and removed request for
ihnorton
* Remove ``axis_type`` parameter from ``create`` * Add parameters to specify initial Image URI. * Add ``data_axis_order`` to ``create`` and ``read_spatial_region``.
* Fix DenseNDArray types to be _DenseND * Add return type for the new `set` methods * Add `data_axis_order` property * Add `has_channel_axis` property * Add `nchannel` property * Fix docstring for `level_shape`
jp-dark
force-pushed
the
dark/multiscale-image
branch
from
08b795e
to
828dfe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback from PR #219 regarding the
MultiscaleImageAPI. It includes the following changes:CoordinateSpaceas a creation parameter.image_typeproperty/creation parameter. Usedata_axis_orderinstead which uses the axis names the user provided.MultiscaleImage.add_new_levelto only add images smaller than the base (level=0) image.setmethod for adding images that exist outside of SOMA.ImagePropertiesclass.