Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion re introducing sc_group vs sc_dataset #17

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

falexwolf
Copy link
Contributor

@falexwolf falexwolf commented Mar 5, 2022

Extending discussion here: #11

  • This would change the sequence and first introduce sc_group & sc_dataset and then talk about the specification within sc_group.
  • It would make identifications with existing formats on the level of sc_group and not on the level of the fields within sc_group.

There is also a question here regarding "allowing arbitrary collections of dataframes" vs. aligned multi-dimensional annotations (#3).

Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and I'd be happy to see them merged. Pending the nit below.

@aaronwolen Could you provide a second opinion? Is there anything here you think should be changed?

specification.md Outdated Show resolved Hide resolved
@aaronwolen
Copy link
Member

Looks great. I agree that starting with descriptions of the higher-level components and including their anndata/seurat/bioc analogs will help readers get oriented more quickly.

Related but probably for a separate PR:

  • I think we should bump-up the matrix.png diagram to come before Notes:
  • and some of those bullets could be folded into the revised descriptions (e.g., There can be more than one X arrays...)

@ambrosejcarr ambrosejcarr merged commit 84a5b3e into single-cell-data:main Mar 9, 2022
@ambrosejcarr
Copy link
Member

Thanks for this suggestion @falexwolf !

@falexwolf falexwolf deleted the patch-1 branch March 10, 2022 09:10
@falexwolf
Copy link
Contributor Author

Thanks for merging! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants