Skip to content

Commit

Permalink
Remove optional keyword args from IndexLike.get_indexer (#190)
Browse files Browse the repository at this point in the history
We only use the `target` positional argument from the pandas `Index.get_indexer` method. Remove optional keyword arguments to allow greater flexibility when implementing a `IndexLike` class.
  • Loading branch information
jp-dark authored Mar 22, 2024
1 parent 316333f commit f8bdce6
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions python-spec/src/somacore/query/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,7 @@ class IndexLike(Protocol):
not as a full specification of the types and behavior of ``get_indexer``.
"""

def get_indexer(
self,
target: npt.NDArray[np.int64],
method: object = ...,
limit: object = ...,
tolerance: object = ...,
) -> Any:
def get_indexer(self, target: npt.NDArray[np.int64]) -> Any:
"""Something compatible with Pandas' Index.get_indexer method."""


Expand Down

0 comments on commit f8bdce6

Please sign in to comment.