Major refactor of application, with new USB communication back-end. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Rewrote all USB communication code -Added direct support for WinUSB on Windows -Fixed data corruption issues on Windows/Linux -Added the ability to send manual player serial control commands -Added .json metadata file to accompany captures -Added support for selecting between multiple USB devices -Separated core USB communication from Qt platform as prep for command line capture app.
Qt5 holds us back from C++20 features, and it's not relevant in 2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Rewrote all USB communication code
-Added direct support for WinUSB on Windows
-Fixed data corruption issues on Windows/Linux
-Added the ability to send manual player serial control commands -Added .json metadata file to accompany captures
-Added support for selecting between multiple USB devices -Separated core USB communication from Qt platform as prep for command line capture app.
Note that as part of this change, I dropped support for Qt5, and updated the C++ standard to C++20, in order to enable features I wanted to use in the new USB comms code. Code can still be compiled under Ubuntu 22.04 LTS.
Over half the codebase is new code after this change. The new code I added doesn't entirely fit in with the style of the existing UI code. The original plan was to make all the new code a static library, fully separated from the monolithic Qt codebase, which would have used consistent styling. In the end I folded the code into the existing project when I decided not to go ahead with a command line capture app as part of this same change. The idea is still to add that later.
I wanted to keep the core USB comms part separated from Qt, as Qt likes to take over everything and brings all its custom types that bleed throughout the codebase, and IMO it's better to contain to the GUI sections. A lot of the threading problems were due to the use of QT for threading and messaging, which basically serialized everything onto the UI thread. I severed the dependency on Qt at the lower levels and contained it to UI instead, and unfortunately the existing serial comms part which I didn't refactor as part of this, but would need to be done for the command line app. This keeps the core of the application lightweight and highly portable, so that it now only brings STL dependencies.