Refactoring API #36
Merged
Refactoring API #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing API:
Currently, we mesh from an OrderedDict of meshwell entities, and use the keys for physical names
With this change, we mesh from a list of meshwell entities, with the meshwell entities having new attributes:
The advantage of this is that now multiple independent meshwell entities can share the same physical name
This is also required to "break up" ill-formed entities introduced when buffering polygons @HelgeGehring
Eventually we should also move resolution parameters from a dict to an attribute of the entities