first attempt of a soleil reader which can read a stack of images. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picca
force-pushed
the
master
branch
5 times, most recently
from
6de4cb2
to
4e2f938
Compare
kif
reviewed
Jul 29, 2019
| obj = fabioformats.factory(klass_name) | ||
| objs.append(obj) | ||
| except (RuntimeError, Exception): | ||
| pass |
There was a problem hiding this comment.
We should a least log the fact there was an exception ...
Beside this Runtime derives from Exception ...
In [4]: RuntimeError.__mro__
Out[4]: (RuntimeError, StandardError, Exception, BaseException, object)
So except Exception as err should be enough
|
Can you provide us with a test and a reference test-image ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, can you tel me if this is ok for you
thanks
Fred, with this I can read a soleil file a see a stack of image out of the box from fabio_viewer