Fix currency formatting #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See silvershop#811 Can be removed if Total() works like other DB Fields
|
All checks are green so I'm happy |
|
disabling the Amount method breaks the ShowInTable() function in OrderDiscountModifier in the Discount Module. |
|
@chromos33 Thanks for reporting this. Can you please try changing OrderDiscountModifier's ShowInTable() method to: so using the magic DB-Field value directly instead of the getter method |
wernerkrauss
added a commit
that referenced
this pull request
Feb 20, 2024
* Order: helper method for nice formatting of Total in GridFields See #811 Can be removed if Total() works like other DB Fields * OrderModifier: disable Amount() method See #811 * OrderModifier: show short class name in summary fields * shop reports: format currency values as currency * fix linting errors
wernerkrauss
added a commit
to silvershop/silvershop-discounts
that referenced
this pull request
Feb 26, 2024
See silvershop/silvershop-core#814 ; was removed there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow related to #779 some more formatting for different prices in the backend.
For formatting payments see silverstripe/silverstripe-omnipay#244
@wilr and/or @forsdahl please have a look at this PR and merge if possible. I disabled OrderModifier's Amount() method which should be fine IMHO but could possibly break some stuff.