Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#823: Added horizontal scrollbar for Global Export Configuration pop-up #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

halfcurry
Copy link
Contributor

Hi,
I have added the elementsGrid to a ScrollPanel under the Global Export Configuration pop-up, so now we can scroll and see all the information. Please mention any further requirements.
screenshot from 2017-04-02 17-04-46

@osarrat
Copy link
Member

osarrat commented Apr 3, 2017

I've tested this PR locally, and I can't get the vertical scrollbar on my Firefox on Windows.
Have you tested it on Windows ?
In case this difference come from compilation, can you maybe send to me your generated .war on which you have this vertical scrollbar ?

@halfcurry
Copy link
Contributor Author

I tested it out on Firefox and Chrome in Ubuntu, and it seems to work fine ( as shown in the screenshot ). I am unable to test it on Windows due to some issues. The war file is too big to send over mail. I'll continue working on this.

@osarrat
Copy link
Member

osarrat commented Apr 7, 2017

Hi @indianauthority97 , you can send and share your war through a service like https://wetransfer.com/
@niksj will try to see if she can see your issue as solved on her own Windows environment.

@halfcurry
Copy link
Contributor Author

Hi @osarrat @niksj , I made a commit with minor modifications. Please inform me if it worked. Also, I sent the previous war file to you earlier today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants