Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status only "Available" for project model with attached projects swit… #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niksj
Copy link
Member

@niksj niksj commented Apr 2, 2016

fix for issue: 0000826

@ghost ghost self-assigned this Apr 4, 2016
@ghost
Copy link

ghost commented Apr 4, 2016

Thanks @niksj.

Seems OK to me for the code, @osarrat can you test that (or just look at the code) it's OK from a functional point of view?

@ghost ghost assigned osarrat and unassigned ghost Apr 4, 2016
@osarrat
Copy link
Member

osarrat commented Jun 8, 2016

Thanks @niksj for this work!
Actually, on the functional point of view, your fix is not yet doing the job. Your fix is aiming to ban a shift from Draft to any target status which is not either Ready or Used. This is correct, but not enough.
I have tried your code, and if a Draft project model has a draft project created from it, when I shift its status to "Ready", it is not automatically shifted to "Available & used" as it should since a draft project is attached to it and transformed into a real project.
It is a good start but there is still some work to do on this issue ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants