v6.5.1

RELEASENOTES.json

@@ -1,4 +1,16 @@
 {
+  "6.5.1": {
+    "🍾 features": [
+      "Adds preference: application auto updates"
+    ],
+    "🚨 fixed": [
+      "Fixes Notification Mirroring (#70)"
+    ],
+    "👷 internals": [
+      "Upgrades `node_modules`",
+      "Upgrades `services`"
+    ]
+  },
   "6.5.0": {
     "💎 improved": [
       "Various stability and performance improvements"

app/scripts/main/components/application.js

@@ -6,7 +6,7 @@
  * Node
  * @constant
  */
-const EventEmitter = require('events');
+const events = require('events');
 const path = require('path');
 
 /**
@@ -24,21 +24,18 @@ const { app, BrowserWindow } = electron;
  */
 const appRootPath = require('app-root-path');
 const logger = require('@sidneys/logger')({ write: true });
+const platformTools = require('@sidneys/platform-tools');
 
 /**
  * Modules
  * Configuration
  */
-EventEmitter.defaultMaxListeners = Infinity;
-appRootPath.setPath(path.join(__dirname, '..', '..', '..', '..'));
-
-
-/**
- * App
- * Configuration
- */
 app.disableHardwareAcceleration();
-
+appRootPath.setPath(path.join(__dirname, '..', '..', '..', '..'));
+events.EventEmitter.defaultMaxListeners = Infinity;
+if (platformTools.isLinux) {
+    process.env.XDG_CURRENT_DESKTOP = 'Unity';
+}
 
 /**
  * Modules

app/scripts/main/managers/configuration-manager.js

@@ -121,7 +121,27 @@ let setAppTrayOnly = (trayOnly) => {
  */
 let configurationItems = {
     /**
-     * Application changelog
+     * appAutoUpdate
+     */
+    appAutoUpdate: {
+        keypath: 'appAutoUpdate',
+        default: false,
+        init() {
+            logger.debug(this.keypath, 'init');
+        },
+        get() {
+            logger.debug(this.keypath, 'get');
+
+            return electronSettings.get(this.keypath);
+        },
+        set(value) {
+            logger.debug(this.keypath, 'set');
+
+            electronSettings.set(this.keypath, value);
+        }
+    },
+    /**
+     * appChangelog
      */
     appChangelog: {
         keypath: 'appChangelog',
@@ -141,7 +161,7 @@ let configurationItems = {
         }
     },
     /**
-     * Application's last version update
+     * appLastVersion
      */
     appLastVersion: {
         keypath: 'appLastVersion',
@@ -161,7 +181,7 @@ let configurationItems = {
         }
     },
     /**
-     * Launch on startup
+     * appLaunchOnStartup
      */
     appLaunchOnStartup: {
         keypath: 'appLaunchOnStartup',
@@ -193,7 +213,7 @@ let configurationItems = {
         }
     },
     /**
-     * Application log file
+     * appLogFile
      */
     appLogFile: {
         keypath: 'appLogFile',
@@ -213,7 +233,7 @@ let configurationItems = {
         }
     },
     /**
-     * Show notification badge count (macOS)
+     * appShowBadgeCount
      */
     appShowBadgeCount: {
         keypath: 'appShowBadgeCount',
@@ -243,7 +263,7 @@ let configurationItems = {
         }
     },
     /**
-     * Show application in menubar / taskbar only
+     * appTrayOnly
      */
     appTrayOnly: {
         keypath: 'appTrayOnly',
@@ -271,7 +291,7 @@ let configurationItems = {
         }
     },
     /**
-     * Window bounds
+     * windowBounds
      */
     windowBounds: {
         keypath: 'windowBounds',
@@ -319,7 +339,7 @@ let configurationItems = {
         }
     },
     /**
-     * Window always on top
+     * windowTopmost
      */
     windowTopmost: {
         keypath: 'windowTopmost',
@@ -358,7 +378,7 @@ let configurationItems = {
         }
     },
     /**
-     * Window visibility
+     * windowVisible
      */
     windowVisible: {
         keypath: 'windowVisible',
@@ -407,7 +427,7 @@ let configurationItems = {
         }
     },
     /**
-     * Hide notification message body
+     * pushbulletHideNotificationBody
      */
     pushbulletHideNotificationBody: {
         keypath: 'pushbulletHideNotificationBody',
@@ -427,7 +447,7 @@ let configurationItems = {
         }
     },
     /**
-     * Last notification timestamp
+     * pushbulletLastNotificationTimestamp
      */
     pushbulletLastNotificationTimestamp: {
         keypath: 'pushbulletLastNotificationTimestamp',
@@ -447,7 +467,7 @@ let configurationItems = {
         }
     },
     /**
-     * Repeat recent pushes on launch
+     * pushbulletRepeatRecentNotifications
      */
     pushbulletRepeatRecentNotifications: {
         keypath: 'pushbulletRepeatRecentNotifications',
@@ -467,7 +487,7 @@ let configurationItems = {
         }
     },
     /**
-     * Notification sound on / off
+     * pushbulletSoundEnabled
      */
     pushbulletSoundEnabled: {
         keypath: 'pushbulletSoundEnabled',
@@ -486,9 +506,8 @@ let configurationItems = {
             electronSettings.set(this.keypath, value);
         }
     },
-    /** @namespace fs.existsSync */
     /**
-     * Notification sound file
+     * pushbulletSoundFile
      */
     pushbulletSoundFile: {
         keypath: 'pushbulletSoundFile',
@@ -511,7 +530,7 @@ let configurationItems = {
         }
     },
     /**
-     * Notification sound volume
+     * pushbulletSoundVolume
      */
     pushbulletSoundVolume: {
         keypath: 'pushbulletSoundVolume',
@@ -531,7 +550,7 @@ let configurationItems = {
         }
     },
     /**
-     * Mirrored SMS
+     * pushbulletSmsEnabled
      */
     pushbulletSmsEnabled: {
         keypath: 'pushbulletSmsEnabled',

app/scripts/main/menus/tray-menu.js

@@ -61,6 +61,7 @@ const trayIconTransparentPause = path.join(appRootPath, 'app', 'images', `${plat
  * Tray images
  * @constant
  */
+const trayMenuItemImageAppAutoUpdate = path.join(appRootPath, 'app', 'images', `tray-item-appAutoUpdate${platformTools.menuItemImageExtension}`);
 const trayMenuItemImageAppLaunchOnStartup = path.join(appRootPath, 'app', 'images', `tray-item-appLaunchOnStartup${platformTools.menuItemImageExtension}`);
 const trayMenuItemImageAppShowBadgeCount = path.join(appRootPath, 'app', 'images', `tray-item-appShowBadgeCount${platformTools.menuItemImageExtension}`);
 const trayMenuItemImageAppTrayOnly = path.join(appRootPath, 'app', 'images', `tray-item-appTrayOnly${platformTools.menuItemImageExtension}`);
@@ -110,6 +111,19 @@ let createTrayMenuTemplate = () => {
         {
             type: 'separator'
         },
+        {
+            id: 'appAutoUpdate',
+            label: 'Automatic App Updates',
+            icon: trayMenuItemImageAppAutoUpdate,
+            type: 'checkbox',
+            checked: configurationManager('appAutoUpdate').get(),
+            click(menuItem) {
+                configurationManager('appAutoUpdate').set(menuItem.checked);
+            }
+        },
+        {
+            type: 'separator'
+        },
         {
             id: 'reset',
             label: 'Reset Configuration...',
@@ -342,9 +356,11 @@ let createTrayMenuTemplate = () => {
 class TrayMenu extends Tray {
     /**
      * @param {Electron.MenuItemConstructorOptions[]} template - Menu template
-     * @constructs
+     * @constructor
      */
     constructor(template) {
+        logger.debug('constructor');
+
         super(trayIconDefault);
 
         this.template = template;

app/scripts/main/services/updater-service.js

@@ -55,26 +55,32 @@ let getMainWindow = () => global.mainWindow;
 
 
 /**
- * Retrieve AppChangelog
+ * Retrieve appAutoUpdate
+ * @return {Boolean} - Yes / no
+ */
+let retrieveAppAutoUpdate = () => configurationManager('appAutoUpdate').get();
+
+/**
+ * Retrieve appChangelog
  * @return {String} - changelog
  */
 let retrieveAppChangelog = () => configurationManager('appChangelog').get();
 
 /**
- * Store AppChangelog
+ * Store appChangelog
  * @param {String} changelog - Changelog
  * @return {void}
  */
 let storeAppChangelog = (changelog) => configurationManager('appChangelog').set(changelog);
 
 /**
- * Retrieve AppLastVersion
+ * Retrieve appLastVersion
  * @return {String} - Version
  */
 let retrieveAppLastVersion = () => configurationManager('appLastVersion').get();
 
 /**
- * Store AppLastVersion
+ * Store appLastVersion
  * @param {String} version - Version
  * @return {void}
  */
@@ -88,9 +94,11 @@ let storeAppLastVersion = (version) => configurationManager('appLastVersion').se
  */
 class UpdaterService {
     /**
-     * @constructs
+     * @constructor
      */
     constructor() {
+        logger.debug('constructor');
+
         // Do not run with debug Electron application
         if (process.defaultApp) { return; }
 
@@ -216,7 +224,7 @@ class UpdaterService {
                 });
         });
 
-        this.autoUpdater.checkForUpdates();
+        this.checkForUpdates();
     }
 
     /**
@@ -253,7 +261,40 @@ class UpdaterService {
             const notification = notificationProvider.create({ title: `Update installed for ${appProductName}`, subtitle: appCurrentVersion });
             notification.show();
         }
+    }
 
+    /**
+     * Check if updater is ready
+     * @return {Boolean} - Yes / no
+     */
+    isAvailable() {
+        logger.debug('isAvailable');
+
+        return Boolean(this.autoUpdater);
+    }
+
+    /**
+     * Check if currently updating
+     * @return {Boolean} - Yes / no
+     */
+    isActive() {
+        logger.debug('isActive');
+
+        return Boolean(this.isUpdating);
+    }
+
+    /**
+     * Check for updates
+     */
+    checkForUpdates() {
+        logger.debug('checkForUpdates');
+
+        if (!this.isAvailable()) { return; }
+        if (this.isActive()) { return; }
+
+        if (!retrieveAppAutoUpdate()) { return; }
+
+        this.autoUpdater.checkForUpdates();
     }
 }
 
@@ -277,15 +318,9 @@ let init = () => {
 app.on('browser-window-focus', () => {
     logger.debug('app#browser-window-focus');
 
-    if (!global.updaterService) { init(); }
+    if (!global.updaterService) { return; }
 
-    if (!global.updaterService.autoUpdater) { return; }
-
-    if (Boolean(global.updaterService.isUpdating) === false) {
-        if (global.updaterService.autoUpdater.checkForUpdates) {
-            global.updaterService.autoUpdater.checkForUpdates();
-        }
-    }
+    global.updaterService.checkForUpdates();
 });
 
 /**