Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix/#205/project detail/robots] 성능 및 검색엔진 개선 #206

Merged
merged 3 commits into from
Apr 5, 2024
Merged

[Hotfix/#205/project detail/robots] 성능 및 검색엔진 개선 #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a3359e
[Change 🚜 ] robots.txt public안으로 이동
Whoknow77 Apr 5, 2024
8a008e8
[Refactoring ⚙️] Link 태그에 #추가
Whoknow77 Apr 5, 2024
1ca94bf
[Refactoring ⚙️] objectfit cover 추가
Whoknow77 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 robots.txt → public/robots.txt
View file
Open in desktop
File renamed without changes.
Binary file removed src/assets/images/noImage.jpg
View file
Open in desktop
Binary file not shown.
Binary file added src/assets/images/noImage.webp
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions src/pages/ProjectDetailPage/ProjectDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import FullScreenSpinner from "@components/LoadingComponents/FullScreenSpinner"

import { ProjectDetailPageMetaData } from "../../components/ MetaData/MetaData"
import Comments from "./components/Comments/Comments"
// import Content from "./components/Content/Content"
import Content from "./components/Content/Content"
import { ProjectIdProps, withProjectId } from "./components/Hoc/withProjectId"
import Summary from "./components/Summary/Summary"
import { useProjectDetailQuery } from "./hooks/queries/useProjectDetailQuery"
Expand All @@ -28,7 +28,7 @@ const ProjectDetailPage = ({ projectId }: ProjectIdProps) => {
p="5rem"
gap="10rem"
direction="column">
{/* <Content projectDetailInfo={projectDetailInfo} /> */}
<Content projectDetailInfo={projectDetailInfo} />
<Comments comments={projectDetailInfo.comments}></Comments>
</Flex>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ProjectDetailPage/components/EmptyMessage/EmptyMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ interface EmptyMessageProps {
const EmptyMessage = ({ type }: EmptyMessageProps) => {
return (
<Text
color="grey.500"
color="blue.100"
fontSize="lg">
{EMPTY_MESSAGE[type]}
</Text>
Expand Down
7 changes: 4 additions & 3 deletions src/pages/ProjectDetailPage/components/Summary/SummaryContent/SummaryRight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Keyboard, Mousewheel, Navigation, Pagination } from "swiper/modules"
import { SwiperSlide } from "swiper/react"
import { Swiper as SwiperCore } from "swiper/types"

import noImage from "@assets/images/noImage.jpg"
import noImage from "@assets/images/noImage.webp"

import { StyledSwiper } from "../../../styles/SwiperSlide.styles"
import SwiperButton from "./SwiperButton"
Expand Down Expand Up @@ -43,7 +43,6 @@ const SummaryRight = ({ overviewImageUrl }: SummaryRightProps) => {
{overviewImageUrl?.map((overviewImg) => (
<SwiperSlide key={overviewImg.id}>
<Image
loading="lazy"
src={overviewImg.url}
fallbackSrc={noImage}
alt="overviewImg"
Expand All @@ -53,8 +52,10 @@ const SummaryRight = ({ overviewImageUrl }: SummaryRightProps) => {
</StyledSwiper>
) : (
<Image
width="100%"
height="100%"
objectFit="cover"
src={noImage}
loading="lazy"
fallbackSrc={noImage}
alt="defaultOverviewImg"
/>
Expand Down
1 change: 1 addition & 0 deletions src/pages/ProjectDetailPage/components/Summary/SummaryTop/SummaryTop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ const SummaryTop = ({
/>
{isLargerThan768 && (
<Link
href="#Comment"
to="Comment"
spy={true}
offset={-100}
Expand Down
1 change: 0 additions & 1 deletion src/pages/ProjectEditPage/components/Files/Overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ const Overview = () => {
<Image
src={image}
key={idx}
loading="lazy"
width="100%"
height="100%"
objectFit="contain"
Expand Down