Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor/#191/project detail/comment] 댓글 컴포넌트 리팩토링 #197

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

Whoknow77
Copy link
Contributor

#️⃣연관된 이슈

#191

💡 핵심적으로 구현된 사항

  • 기존에 따로 만든 Avatar컴포넌트를 사용하지않고 전역에 있는 AvatarCard 공통 컴포넌트 사용
  • 컴포넌트명, 함수명 변경
  • 댓글 item 파일 구조 변경

➕ 그 외에 추가적으로 구현된 사항

🤔 테스트,검증 && 고민 사항

📌 PR Comment 작성 시 Prefix for Reviewers

@Whoknow77 Whoknow77 added the Refactor 리팩토링 label Apr 2, 2024
@Whoknow77 Whoknow77 requested review from miloul and wdgWon April 2, 2024 07:54
@Whoknow77 Whoknow77 linked an issue Apr 2, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@wdgWon wdgWon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 고생하셨습니다!
넣을건 넣고 뺄건 빼고 깔끔하게 정리된 것 같네요!
프로젝트 일정 끝나고도 열심히 하시는 모습 본받겠습니다 👍
고생많으셨어요~!

src/components/AvatarCard/AvatarCard.tsx Outdated Show resolved Hide resolved
@Whoknow77 Whoknow77 merged commit 41c0950 into dev Apr 4, 2024
@Whoknow77 Whoknow77 deleted the refactor/#191/ProjectDetail/Comment branch April 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로젝트 상세정보 페이지 리팩토링(댓글위주)
2 participants