Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor/#134/ProfileEditPage] #148

Merged
merged 6 commits into from
Mar 19, 2024
Merged

[refactor/#134/ProfileEditPage] #148

merged 6 commits into from
Mar 19, 2024

Conversation

hellosonic-r
Copy link
Contributor

#️⃣연관된 이슈

close #134

💡 핵심적으로 구현된 사항

  • career 정보를 수정했습니다.
  • 아바타 옆 플러스 뱃지를 추가했습니다.
  • 서버에서 이미지 url을 받아오는 동안 버튼을 loading, disabled 처리 했습니다.
스크린샷 2024-03-19 오전 11 33 01 스크린샷 2024-03-19 오전 11 33 57

➕ 그 외에 추가적으로 구현된 사항

🤔 테스트,검증 && 고민 사항

📌 PR Comment 작성 시 Prefix for Reviewers

@hellosonic-r hellosonic-r added HotFix 버그 픽스 Minor 마이너한 수정사항 labels Mar 19, 2024
@hellosonic-r hellosonic-r added this to the 6차 스프린트 milestone Mar 19, 2024
@hellosonic-r hellosonic-r self-assigned this Mar 19, 2024
@hellosonic-r hellosonic-r merged commit 8bea2f6 into dev Mar 19, 2024
1 check passed
@hellosonic-r hellosonic-r deleted the refactor/#134/ProfileEditPage branch March 21, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Whoknow77 Whoknow77 Whoknow77 approved these changes

@miloul miloul miloul approved these changes

@wdgWon wdgWon Awaiting requested review from wdgWon

@whdgur5717 whdgur5717 Awaiting requested review from whdgur5717

Assignees

@hellosonic-r hellosonic-r

Labels
HotFix 버그 픽스 Minor 마이너한 수정사항
Projects
None yet
Milestone
6차 스프린트
Development

Successfully merging this pull request may close these issues.

프로필 수정 페이지 리팩토링
3 participants
@hellosonic-r @miloul @Whoknow77