Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Featrue/#79/fix home page] 홈페이지 수정 + 더보기, 무한스크롤 #107

Merged
merged 26 commits into from
Mar 18, 2024
Merged

[Featrue/#79/fix home page] 홈페이지 수정 + 더보기, 무한스크롤 #107

merged 26 commits into from
Mar 18, 2024

Conversation

miloul
Copy link
Contributor

@miloul miloul commented Mar 12, 2024 •
edited
Loading

#️⃣연관된 이슈

close #79

💡 핵심적으로 구현된 사항

  • 배너 사이즈 줄이기
  • 배너 0개일때
    image
  • 홈 페이지 반응형
  • 약간의 리팩토링..
  • api 연동
    2024-03-12143047-ezgif com-video-to-gif-converter
  • 더보기, 무한스크롤

🤔 테스트,검증 && 고민 사항

ProjectListSection에서 isInfinityScroll을 prop으로 내려주고 값에 따라 무한스크롤 혹은 더보기를 수행하는데 해당해서 괜찮을까요 아니면 분리해야할까용

📌 PR Comment 작성 시 Prefix for Reviewers

@miloul miloul added Feat 기능 구현 Refactor 리팩토링 labels Mar 12, 2024
@miloul miloul self-assigned this Mar 12, 2024
@miloul miloul closed this Mar 13, 2024
@miloul miloul reopened this Mar 13, 2024
whdgur5717
whdgur5717 reviewed Mar 13, 2024
View reviewed changes
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/hooks/queries/useAllProjectQuery.ts Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/hooks/queries/useAllProjectQuery.ts Outdated Show resolved Hide resolved
src/pages/HomePage/hooks/queries/useAllProjectQuery.ts Show resolved Hide resolved
wdgWon
wdgWon approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@wdgWon wdgWon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다!
종혁님이 꼼꼼하게 해주셔서 전 별로 할게 없네요 ㅎㅎ;;
혹시 안되거나 힘든 부분 있으시면 말씀해주세요!
기능 구현 하시느라 고생하셨습니다~!

src/assets/images/sidepeek_blue.png Outdated Show resolved Hide resolved
src/pages/HomePage/mocks/index.ts Outdated Show resolved Hide resolved
@miloul miloul changed the title [Featrue/#79/fix home page] 홈페이지 수정 [Featrue/#79/fix home page] 홈페이지 수정 + 더보기, 무한스크롤 Mar 18, 2024
@miloul miloul merged commit c3f3eff into dev Mar 18, 2024
1 check passed
@miloul miloul deleted the featrue/#79/FixHomePage branch March 18, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whdgur5717 whdgur5717 whdgur5717 left review comments

@Duckuism Duckuism Duckuism left review comments

@hellosonic-r hellosonic-r Awaiting requested review from hellosonic-r

@wdgWon wdgWon Awaiting requested review from wdgWon

Assignees

@miloul miloul

Labels
Feat 기능 구현 Refactor 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

메인(홈) 페이지 수정사항
4 participants
@miloul @Duckuism @whdgur5717 @wdgWon