improvement: bump sqlx to 0.8 in database examples #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
approved these changes
Jul 29, 2024
| sqlx = { version = "0.7.3", features = ["runtime-tokio-native-tls", "postgres"] } | ||
| shuttle-runtime = "0.46.0" | ||
| shuttle-shared-db = { version = "0.46.0", features = ["postgres"] } | ||
| sqlx = { version = "0.7.1", features = ["runtime-tokio-native-tls", "postgres"] } |
There was a problem hiding this comment.
This has to stay on a lower version of runtime+shared-db for a while since the cargo+sqlx feature bug pulls in 2 versions of libsqlite. Seems like it's impossible to support both versions (like for axum) due to it. cc @oddgrd
|
Got it. Do you want me to make the change and submit a new PR? It looks like it's already taken care of. |
|
It should be all done. Just sharing context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)