fix: debug.traceback includes proper names instead of chunks #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWeini
force-pushed
the
debug_traceback
branch
from
29f47ec
to
bfa9f8f
Compare
veger
approved these changes
Nov 9, 2024
shpaass
approved these changes
Nov 9, 2024
shpaass
force-pushed
the
debug_traceback
branch
from
bfa9f8f
to
9507312
Compare
|
Rebased on fresh master |
|
The Kux mod now loads successfully. Thank you for the fix, @SWeini! |
Oh no... there goes my test case 😛 BTW There is not a changelog entry for this fix! |
|
Added a changelog entry 40a8bb5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mods rely on the lua function
debug.tracebackand its very specific format to work correctly.This PR overrides
debug.tracebackwith a method that replaces the chunk IDs with the__modname__/path/to/file.luaformat that is expected.