Focus input field when clicking set building count or set production count #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
approved these changes
Oct 25, 2024
|
Leaving this PR open a bit longer for others to take a look. |
veger
reviewed
Oct 26, 2024
|
Besides my nitpick, it looks good to me |
veger
approved these changes
Oct 26, 2024
DaleStan
deleted the
297-focus-input-field-when-clicking-set-building-count-or-set-production-count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297; I checked that the focusing the sheet name still happens when adding a new production sheet and doesn't happen when editing an existing sheet.
I also found a subtle UI wart and worked around it in 9da8948; it becomes more visible now that the fixed and built counts are focused more often.