Improve ScrollArea #325
Merged
Improve ScrollArea #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
force-pushed
the
improve_scrollarea
branch
2 times, most recently
from
4a91fab
to
52491b1
Compare
|
I'm thinking about merging this one after the transition to Factorio 2.0 is done with bugfixes. |
shpaass
force-pushed
the
improve_scrollarea
branch
from
52491b1
to
d8daddc
Compare
|
Added a space after commit prefixes |
|
Thank you for the improvements! |
Required when a parent needs to calculate exact row height.
This way it is dependent on the actual icon sizes, instead of the hardcoded sizes.
This prevents 'compressing' empty rows in the SummaryView
It is interesting for parents, in order to layout the other components in the parent context.
…ly consumed Removes the 'fallback' of horizontal scrolling without CTRL when the vertical scrollbar is not present. It is confusing and breaking underlying panels (as they won't receive (expected) events.
shpaass
force-pushed
the
improve_scrollarea
branch
from
d8daddc
to
e62af5f
Compare
|
Rebased on fresh master |
shpaass
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a collection of small improvements and preparation for freezing the first column (tab/page name column) of the SummaryView ScrollArea. This is working almost fully working and I am using it locally all the time: the only left-over issue is that the the scrollbars are disappeared. (so the UX is a little off 😉 )
I pushed this 'freeze-first-summary-column' branch with this fix to my own fork, so it is be more publicly available, until I (or someone) is able to fix the missing scrollbars, so we can actually merge!
I have these changes for ages in my local repo, and I do think these are suitable on their own to be committed. It will help me (re)fixing them on style changes or other code changes.
Each change is a separate commit (as I think we should keep them), so it is fairly easy if we do not like one of them (then I'll move back to my freeze-first-summary-column where most of them are required to make this feature work.
For testing I opened up YAFC and clicked around a bit, all still seem to be working/rendering the same, except: