ci: Add a pre-push hook that checks formatting #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
reviewed
Sep 20, 2024
|
Rebased on fresh master and added a new line at the end of the |
skullbearer
approved these changes
Oct 5, 2024
Also add a script that enables this hook. It cannot be enabled automatically due to git security. Essentially, every contributor needs to run that script once on their machine to enable that hook. Update the documentation to mention the script. Fixes #295
|
Rebased on fresh master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pre-push hook that checks formatting.
Add a script that enables this hook. It cannot be enabled automatically due to git security. Essentially, every contributor needs to run that script once on their machine to enable that hook.
Update the documentation to mention the script.
Fixes #295 ([Devops] Investigate git hooks for dotnet format)
Essentially, this PR prevents the issue where you pushed the code and discovered that the formatting check doesn't pass only at the PR stage.