fix(split): vsplits integration resize inconsistencies #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
deleted the
fix/split-and-integration-resize-inconsistencies
branch
shortcuts
pushed a commit
that referenced
this pull request
Sep 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.1](v2.0.0...v2.0.1) (2024-09-09) ### Bug Fixes * **split:** vsplits integration resize inconsistencies ([#391](#391)) ([09736f4](09736f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Summary
rework the way we compute the size of side buffers by properly assessing the number of valid sides, which was causing weird layout when 2 were actives.
also resize the vsplits based on the layout, rather than guessing which windows are vsplits, this allows a super consistent ui layout
todo: closing an integration doesn't restore the position of the
currbuffer, but the width is correctcloses #389