Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github actions example to deployer #1539

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shyim
Copy link
Member

@shyim shyim commented Nov 6, 2024

Key changes:

  • The pipeline builds Shopware using shopware-cli
  • Deployment Helper will be used for migrations and installations
  • Added GitHub Action example

@Isengo1989 Isengo1989 self-requested a review November 6, 2024 15:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (2)

guides/hosting/installation-updates/deployments/deployment-with-deployer.md:283

  • The comment should be more specific: 'Increase the timeout value if tasks take longer than 3600 seconds.'
set('default_timeout', 3600); // Increase when tasks take longer than that.

guides/hosting/installation-updates/deployments/deployment-with-deployer.md:186

  • [nitpick] Double-check if '.env.local' is the correct file to be copied instead of '.env'.
cp /var/www/shopware_backup/.env.local /var/www/shopware/shared/.env.local

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @shyim 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants