Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about logging #1239

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Add info about logging #1239

merged 2 commits into from
Dec 21, 2023

Conversation

Isengo1989
Copy link
Collaborator

No description provided.

@JoshuaBehrens
Copy link
Contributor

JoshuaBehrens commented Dec 19, 2023

Can we have a note on how to redirect loggers from plugins to other logging targets? AFAIK is this the sole reason, why we shall not use the logger factory anymore. Looking at it from the perspective of a composer project owner, that needs to change things according to the hosting

@Isengo1989 Isengo1989 marked this pull request as ready for review December 20, 2023 15:15
@Isengo1989
Copy link
Collaborator Author

Can we have a note on how to redirect loggers from plugins to other logging targets? AFAIK is this the sole reason, why we shall not use the logger factory anymore. Looking at it from the perspective of a composer project owner, that needs to change things according to the hosting

I bet we can, but probably not in the scope of this PR. Can you link some info about it (I remember you had a discussion somewhere about the removal of the LoggerFactory)?

In the meantime I will create a internal ticket on the matter.

@JoshuaBehrens
Copy link
Contributor

Yes, the feedback I got from reviving a SW5 service xD shopware/shopware#2766 was in this pull request. And eventually your response was in NEXT-30950 to deprecate the logger factory but how do you now make use of this as a project code owner?

@Isengo1989
Copy link
Collaborator Author

Yes, the feedback I got from reviving a SW5 service xD shopware/shopware#2766 was in this pull request. And eventually your response was in NEXT-30950 to deprecate the logger factory but how do you now make use of this as a project code owner?

Ok, thx for the links. We will look into an example based on https://symfony.com/doc/current/logging/channels_handlers.html

@Isengo1989 Isengo1989 merged commit 71dbe29 into main Dec 21, 2023
8 checks passed
@Isengo1989 Isengo1989 deleted the dx-514/add-monolog-info branch December 21, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants