[engine] Use slices.Contains

Change-Id: I9382e5bece54bb4b3ee1744677d2034f1b51d725 Reviewed-on: https://fuchsia-review.googlesource.com/c/shac-project/shac/+/896618 Fuchsia-Auto-Submit: Oliver Newman <[email protected]> Commit-Queue: Auto-Submit <[email protected]> Reviewed-by: Marc-Antoine Ruel <[email protected]>
shac-project · Aug 7, 2023 · eea6195 · eea6195
1 parent f429c07
commit eea6195
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/internal/engine/runtime_ctx_os.go b/internal/engine/runtime_ctx_os.go
@@ -28,6 +28,7 @@ import (
 	"strings"
 
 	"go.fuchsia.dev/shac-project/shac/internal/sandbox"
+	"go.fuchsia.dev/shac-project/shac/internal/slices"
 	"go.starlark.net/starlark"
 )
 
@@ -108,7 +109,7 @@ func (s *subprocess) wait() (starlark.Value, error) {
 		return nil, errors.New("process returned too much stderr")
 	}
 
-	if !contains(s.okRetcodes, retcode) && s.raiseOnFailure {
+	if !slices.Contains(s.okRetcodes, retcode) && s.raiseOnFailure {
 		var msgBuilder strings.Builder
 		msgBuilder.WriteString(fmt.Sprintf("command failed with exit code %d: %s", retcode, s.args))
 		if s.stderr.Len() > 0 {
@@ -401,12 +402,3 @@ func sequenceToInts(s starlark.Sequence) []int {
 	}
 	return out
 }
-
-func contains[T comparable](slice []T, target T) bool {
-	for _, item := range slice {
-		if item == target {
-			return true
-		}
-	}
-	return false
-}