fix composer install when no ready-made-env exist #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mradcliffe
reviewed
Jan 10, 2022
| # Patch Drush to fix `drush cr` when core is symlinked | ||
| # https://github.com/drush-ops/drush/pull/4713 | ||
| cd "$GITPOD_REPO_ROOT" && \ | ||
| patch -p1 < "$GITPOD_REPO_ROOT"/src/composer-drupal-core-setup/drush-cr-when-core-is-symlinked.patch |
There was a problem hiding this comment.
Will this patch fail if a different version of drush is installed? It seems sort of brittle without being able to determine if it should be patched or not.
There was a problem hiding this comment.
Good question...
https://github.com/Weitzman said this bug will not be fixed in Drush, but a problem that should get fixed in Drupal core itself.
(But I think that even if drupal 9.4 will get this fixed, all previous Drupal versions will still have that issue)
There was a problem hiding this comment.
Reference: drush-ops/drush#4713 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug
Fixes #64
How this PR Solves The Problem
composer create-project, when there were no ready-made-envs for that drupal version.DP_PHP_VERSION=8.0in URL params (will become an official option when new browser extension is released)drush si, it doesn't connect to ddev'sdb, and try to work withdrupaldatabase instead.Manual Testing Instructions
Open this URL -
https://gitpod.io/#DP_PROJECT_NAME=drupal,DP_ISSUE_FORK=drupal-3257163,DP_ISSUE_BRANCH=feature%2F3257163-drupal_media_bundle,DP_PROJECT_TYPE=project_core,DP_MODULE_VERSION=10.0.x,DP_CORE_VERSION=10.0.x,DP_PATCH_FILE=,DP_INSTALL_PROFILE=standard,DP_PHP_VERSION=8.0/https://github.com/shaal/drupalpod/tree/drupal10
Related Issue Link(s)
Release/Deployment notes