-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AppSync): Add JS resolver helper & matchers #79
Conversation
} | ||
} | ||
`); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I removed support for string predicates.
in AppSync, it should always be a JSON anyway.
if the evaluated mapping template is not a valid js, it will throw an error.
doc/matchers/appsync.md
Outdated
|
||
### `appSyncResolver(input: AppSyncResolverInput)` | ||
|
||
- `code`: A string with the `APPSYNC_JS`` resolver code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bayoudhi I am considering changing this to be the path of a file, both in JS and mapping templates (VTL).
I don't think that inline code is useful. Especially in this context.
The code will always live somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question/issue would be to what directory the path should be relative to and how to handle that inside sls-jest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end this is what I did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! Thank you for improving the internal implementation too!
🎉 This PR is included in version 1.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.