-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI Foundry Template (cont.) #905
Open
jimmychu0807
wants to merge
95
commits into
semaphore-protocol:main
Choose a base branch
from
jimmychu0807:jc/854
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+364
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.9.2
…into new_branch
v4.0.3
v4.0.3
v4.0.3
v4.0.3
v4.0.3
Add CLI Foundry Template (cont.)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
I think this PR is ready for review. Thanks. cc @cedoor @vplasencia @sripwoud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completing #854
node_modules
instead of git submodules in this repo.Makefile
.This is a draft PR, but please review the updated approach and see if it is okay.
A few tasks left:
Related Issue(s)
closes #185
Other information
cc @cedoor @vplasencia @sripwoud
cc @timou0911 @csiejimmyliu
I thought I could continue building on top of #854, but end up opening a new PR. Let me know if there is a way / how to do it if this is important enough.
Checklist
yarn format
andyarn lint
without getting any errors