Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI Foundry Template (cont.) #905

Open
wants to merge 95 commits into
base: main
Choose a base branch
from

Conversation

jimmychu0807
Copy link
Contributor

@jimmychu0807 jimmychu0807 commented Nov 28, 2024

Description

Completing #854

  1. Preferring using node_modules instead of git submodules in this repo.
  2. As I am making this a js package with package.json, I removed the Makefile.

This is a draft PR, but please review the updated approach and see if it is okay.

A few tasks left:

  • Enhance the test so it test for event with exact parameters and verify the contract state.
  • Allow running anvil node locally and deploy Feedback.sol to it.
  • Update readme.

Related Issue(s)

closes #185

Other information

cc @cedoor @vplasencia @sripwoud
cc @timou0911 @csiejimmyliu

I thought I could continue building on top of #854, but end up opening a new PR. Let me know if there is a way / how to do it if this is important enough.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

openzeppelin-code bot commented Nov 28, 2024

Add CLI Foundry Template (cont.)

Generated at commit: d96a61100af2d071a38a210102519393f92dae16

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@jimmychu0807
Copy link
Contributor Author

I think this PR is ready for review. Thanks.

cc @cedoor @vplasencia @sripwoud
cc @timou0911 @csiejimmyliu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CLI Foundry template
4 participants